Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use "ffi" suffix for sys crates #737

Merged
merged 2 commits into from Mar 7, 2019
Merged

Don't use "ffi" suffix for sys crates #737

merged 2 commits into from Mar 7, 2019

Conversation

EPashkin
Copy link
Member

@EPashkin EPashkin commented Mar 5, 2019

@GuillaumeGomez
Copy link
Member

👍

@sdroege
Copy link
Member

sdroege commented Mar 6, 2019

See https://github.com/gtk-rs/glib/pull/470/files#r262832438 , otherwise looks all good to me.

@sdroege
Copy link
Member

sdroege commented Mar 6, 2019

See https://github.com/gtk-rs/glib/pull/470/files#r262832438 , otherwise looks all good to me.

I.e., I'd prefer if we also changed sys to $crate_name_sys so that no renaming at all is necessary anymore.

@EPashkin
Copy link
Member Author

EPashkin commented Mar 6, 2019

Ready for final check

@sdroege
Copy link
Member

sdroege commented Mar 7, 2019

👍

@EPashkin EPashkin merged commit 44398d6 into gtk-rs:master Mar 7, 2019
@EPashkin EPashkin deleted the ffi_to_sys branch March 7, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EPashkin @GuillaumeGomez @sdroege